update fork from upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_secret_backend_role: support role_arns argument
Fix for issue #385
skip_tls_verify expects a boolean, but defaulted to an empty string, which causes an error under 0.12.
The test case for updating a v2 generic secret had a check function that hardcoded in the initial value, and then proceeded to check that against the updated value, which would never work. This updates to add a check function for the updated config, with the updated value coded in.
0.12 complained about our plan changing because we were interpolating a backend's path. Backend paths cannot be specified using a trailing / but are always set in state with a trailing /. That means the plan will always change when creating a backend and using it in the same request. This commit changes that to set the backend in state with no trailing slash, which resolves the issue because it will always match user input now. This may be considered a breaking change.
Modify provider_test to load GCP test creds from file _or_ accept them as the contents of the file. Also, run go mod tidy.
The service_account_project field the tests were expecting from the API has been transitioned to the project field. Update the test to check the right field.
We're storing the path in state without the trailing slash, and we need to update the test that assumes we'll have the trailing slash.
Blocks can no longer be specified using =.
Blocks can no longer be specified using =.
Update the error message we're testing agains, as it has changed in 0.12.
The basic LDAP auth backend group test had policies specified as a list, with the util function for turning a slice into a Terraform list inside that list. Except the util helper also returned the square brackets, so we had `[[item, item]]` instead of `[item, item]`. In Terraform 0.11, this was fine. In Terraform 0.12, it is not.
It appears 0.12 doesn't consider HasChange true when the change has been marked by CustomizeDiff? By refactoring the logic for checking if renewal is necessary into a helper function and calling that function again instead of HasChange we can work around this limitation.
Write to a different path with every test run, so our version is predictable.
Upgrade to 0.12
…nt-menu Add sidebar menu link to vault_policy_document document
Minor spelling fixes
Update AWS Auth Backend Role resources to take sets instead of lists
…kend_role_bound_claims Add list type for bound claims of vault_jwt_auth_backend_role
Fix code example
Add STS TTLs to `vault_aws_secret_backend_role`
Always set attribute 'data' if read is disabled
…ibe-paths Add tool for analyzing Vault API coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.