Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example overlay #192

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Add example overlay #192

merged 3 commits into from
Feb 8, 2019

Conversation

mgoodness
Copy link
Contributor

This is the kustomize overlay in use at Ticketmaster. It's a good example (IMHO) of how to add & patch resources to a base configuration.

Michael Goodness added 2 commits February 6, 2019 12:22
Signed-off-by: Michael Goodness <[email protected]>
Signed-off-by: Michael Goodness <[email protected]>
@coveralls
Copy link

coveralls commented Feb 6, 2019

Coverage Status

Coverage remained the same at 19.786% when pulling e7fe6a9 on ticketmaster:tm-overlays into 741c942 on jtblin:master.

Signed-off-by: Michael Goodness <[email protected]>
@jrnt30
Copy link
Collaborator

jrnt30 commented Feb 8, 2019

Thanks for the example, this is useful.

It does seem to reinforce my thought, the args is unable to be merged from base via an overlay which makes "composing" different features via Kustomize less approachable. Is that accurate?

@jrnt30 jrnt30 merged commit d1ede0d into jtblin:master Feb 8, 2019
@mgoodness
Copy link
Contributor Author

"Less approachable" is exactly right. Kustomize allows for JSON patches, which allow operations that YAML does not. An arg, for example, can be appended to the existing array like so:

[
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--foo=bar"
  }
]

But it's JSON, and still somewhat limited (only array indexes, for example).

@mgoodness mgoodness deleted the tm-overlays branch February 8, 2019 16:38
@jrnt30
Copy link
Collaborator

jrnt30 commented Feb 9, 2019

Thanks, good to know it's "possible" at least.

nyodas pushed a commit to DataDog/kube2iam that referenced this pull request Apr 4, 2019
* Move kustomize base to kustomize/base
* Add example overlay

Signed-off-by: Michael Goodness <[email protected]>
jessestuart pushed a commit to jessestuart/kube2iam that referenced this pull request Jul 18, 2019
* Move kustomize base to kustomize/base
* Add example overlay

Signed-off-by: Michael Goodness <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants