Add System.Memory dependency #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
getting this error so far: https://stackoverflow.com/questions/45282478/memorystream-does-not-contain-a-definition-for-getbuffer |
|
You need to change #if NETSTANDARD1_0 to #if NETSTANDARD1_1 |
|
@mkosieradzki good point, thanks! |
jtattermusch
force-pushed
the
add_system_memory_dep
branch
from
90673fe to
0837814
Compare
jtattermusch
force-pushed
the
add_system_memory_dep
branch
from
0837814 to
8cdcf8b
Compare
|
This PR was wrong as well. You forgot to add netstandard1.1 to unconditional TargetFrameworks. I have fixed this in #8 |
|
@mkosieradzki thanks for pointing that out. This should be fixed in a separate PR. Done so in #9 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but based on https://docs.microsoft.com/en-us/dotnet/standard/net-standard (and http://immo.landwerth.net/netstandard-versions/#) the only difference in supported plaforms between netstandard1.0 and netstandard1.1 is that netstandard1.1. doesn't work on Windows Phone Silverlight (but silverlight seems to be deprecated).