Teach sort-comp rule about static class methods #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of people have said that they think it makes sense for static class methods to appear at the very top of classes. This commit allows this to be configured by adding the `static-methods` keyword to the sort-comp rule. Fixes jsx-eslint#128
This word was misspelled.
I noticed a couple of cases where we continue looping even though we don't need to anymore. In these special keyword cases, we can break out of these loops as soon as we find a match to get a little bit of a speed boost.
|
Awesome! 👍 |
|
Can this include static properties too ? |
|
Those don't exist yet. However, it should once they do :-) |
|
Thank you very much for this. But since it can be a breaking change in some configuration I will wait for the next major release to merge it. |
|
Sounds good. Is there anything I can do to help get the next major release out sooner? |
|
Sure. I will publish a checklist (maybe tomorrow) of what I would like to pass in next major release. |
yannickcr
added a commit
that referenced
this pull request
Feb 14, 2016
Add static method support to sort-comp (fixes #128)
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of people have said that they think it makes sense for static
class methods to appear at the very top of classes. This PR allows
this to be configured by adding the
static-methodskeyword to thesort-comp rule.
While I was at it, I fixed a couple of typos and made a minor perf tweak.
Fixes #128