Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-object-type-as-default-prop: enable rule when multiple parameters #3768

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[Fix] no-object-type-as-default-prop: enable rule when multiple parameters #3768

merged 1 commit into from
Jun 13, 2024

Conversation

JulienR1
Copy link
Contributor

Fixes #3767 by allowing components with more than one parameter to be checked by no-object-type-as-default-prop.

ljharb
ljharb approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward, nice!

@ljharb ljharb force-pushed the bug/no-object-type-as-default-prop-issue-3767 branch from 62e7638 to 393bfa2 Compare June 13, 2024 06:07
@ljharb ljharb merged commit 393bfa2 into jsx-eslint:master Jun 13, 2024
327 checks passed
@JulienR1 JulienR1 deleted the bug/no-object-type-as-default-prop-issue-3767 branch June 13, 2024 14:07
RafaelJohn9
RafaelJohn9 reviewed Jun 16, 2024
View reviewed changes
Copy link

@RafaelJohn9 RafaelJohn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍nice

@patooworld patooworld mentioned this pull request Jul 9, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jul 10, 2024
Open
@zdr4k zdr4k mentioned this pull request Jul 10, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jul 10, 2024
Open
This was referenced Jul 10, 2024
Open
Open
Open
Open
Open
Open
@simlarsen simlarsen mentioned this pull request Jul 11, 2024
Merged
@richyhoopd richyhoopd mentioned this pull request Jul 11, 2024
Open
@patooworld patooworld mentioned this pull request Jul 13, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 16, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Jul 16, 2024
Open
This was referenced Jul 17, 2024
Open
Open
Open
@Balantion2020 Balantion2020 mentioned this pull request Jul 17, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jul 18, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 18, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 18, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 4, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 20, 2024
Open
This was referenced Oct 22, 2024
Open
Open
Open
Open
Open
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 25, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 26, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 26, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 27, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 27, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 27, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 28, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 31, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Nov 2, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Nov 2, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Nov 3, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Nov 7, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Nov 7, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Nov 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelJohn9 RafaelJohn9 RafaelJohn9 left review comments

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: react/no-object-type-as-default-prop is disabled when using a ref prop
3 participants
@JulienR1 @ljharb @RafaelJohn9