Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unknown-property add more <video> attributes, onMouseMoveCapture and changes to rule documentation #3390

Merged

Conversation

sjarva
Copy link
Contributor

@sjarva sjarva commented Sep 4, 2022

This PR adds:

  • autoPictureInPicture, controls, controlList, disablePictureInPicture, disableRemotePlayback, loop, muted, poster,preload and allows them only on <video> element
  • allows <line>, <mask> and <use> to have fill property
  • allows onError property on <link> and <source> elements
  • allows onLoad property on <link> element
  • allows numbers in valid data-* properties
  • moves allowFullscreen to case ignored properties
  • unit tests for these properties
  • adds a mention to no-unknown-property rule documentation about ignored properties, when using libraries that pass information with some new props (like css prop when using emotion)

@codecov
Copy link

codecov bot commented Sep 4, 2022

Codecov Report

Merging #3390 (0e72eb6) into master (51ec858) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0e72eb6 differs from pull request most recent head 900d6a2. Consider uploading reports for the commit 900d6a2 to get more accurate results

@@           Coverage Diff           @@
##           master    #3390   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         123      123           
  Lines        8957     8957           
  Branches     3269     3269           
=======================================
  Hits         8741     8741           
  Misses        216      216           
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sjarva sjarva changed the title no-unknown-property add more <video> attributes no-unknown-property add more <video> attributes, onMouseMoveCapture and changes to rule documentation Sep 4, 2022
@ljharb ljharb force-pushed the no-unknown-property-more-video-attributes branch from 0e72eb6 to 900d6a2 Compare September 4, 2022 17:10
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Many of the video attrs also work on audio, so i added those too.

@ljharb ljharb merged commit 900d6a2 into jsx-eslint:master Sep 4, 2022
@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

Looks like it's controlsList, not controlList: #3397

@sjarva sjarva deleted the no-unknown-property-more-video-attributes branch September 5, 2022 09:54
@wereHamster
Copy link

How about onLoad on iframe? I've been successfully using this prop in the past, React handles it fine.

@ljharb
Copy link
Member

ljharb commented Sep 5, 2022

@wereHamster see #3398.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants