[Refactor]: replace util._extend with Object.assign #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 8, 2019
lib/rules/sort-comp.js
Outdated
| @@ -58,7 +57,7 @@ const defaultConfig = { | |||
| function getMethodsOrder(userConfig) { | |||
| userConfig = userConfig || {}; | |||
|
|
|||
| const groups = util._extend(defaultConfig.groups, userConfig.groups); | |||
| const groups = Object.assign(defaultConfig.groups, userConfig.groups); | |||
There was a problem hiding this comment.
this should probably not mutate the default groups - this might be a bug in the rule itself.
Suggested change
| const groups = Object.assign(defaultConfig.groups, userConfig.groups); | |
| const groups = Object.assign({}, defaultConfig.groups, userConfig.groups); |
lib/util/Components.js
Outdated
| @@ -110,7 +109,7 @@ class Components { | |||
| // preserving original array so it can be merged later on. | |||
| copyUsedPropTypes = this._list[id].usedPropTypes && this._list[id].usedPropTypes.slice(); | |||
| } | |||
| this._list[id] = util._extend(this._list[id], props); | |||
| this._list[id] = Object.assign(this._list[id], props); | |||
There was a problem hiding this comment.
this should either be Object.assign(this._list[id], props); or this._list[id] = Object.assign({}, this._list[id], props); - iow, if it's mutating, it shouldn't reassign.
ljharb
reviewed
May 10, 2019
ljharb
approved these changes
May 10, 2019
|
Thanks. |
ljharb
force-pushed
the
remove-util-extends
branch
from
abfe7a2
to
fce69eb
Compare
ljharb
changed the title
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.