Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]prop-types: fix case with destructuring and default param #2246

Merged
merged 1 commit into from
Apr 28, 2019
Merged

[fix]prop-types: fix case with destructuring and default param #2246

merged 1 commit into from
Apr 28, 2019
+38 −6

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Apr 20, 2019

fixes #2241

@ljharb ljharb changed the title [fix]prop-types: fix case with destructuring and defualt param [fix]prop-types: fix case with destructuring and default param Apr 28, 2019
ljharb
ljharb approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a few more test cases but this looks great!

lib/util/usedPropTypes.js Outdated Show resolved Hide resolved
ljharb
ljharb reviewed Apr 28, 2019
View reviewed changes
lib/util/usedPropTypes.js Outdated Show resolved Hide resolved
lib/util/usedPropTypes.js Outdated Show resolved Hide resolved
@ljharb ljharb merged commit 861fdef into jsx-eslint:master Apr 28, 2019
@golopot
Copy link
Contributor Author

golopot commented Apr 28, 2019

Thank you.

@golopot golopot deleted the issue-2241 branch April 28, 2019 18:06
@automatops automatops mentioned this pull request May 3, 2019
Merged
1 task
This was referenced Aug 17, 2019
Open
Open
This was referenced Sep 22, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prop-types not enforced with destructured props and default empty object param
2 participants
@golopot @ljharb