-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state-in-constructor rule #1945
Merged
Merged
Commits on Aug 18, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a312b16 - Browse repository at this point
Copy the full SHA a312b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f06677 - Browse repository at this point
Copy the full SHA 2f06677View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4706e86 - Browse repository at this point
Copy the full SHA 4706e86View commit details
Commits on Aug 19, 2018
-
Remove test cases for
always
option in state-in-constructor ruleSince `always` is the default option, we can use the no-option cases to cover these `always` cases. I left one `always` case to make sure that having an option as `always` will act the same way as no-option.
Configuration menu - View commit details
-
Copy full SHA for 81d0e8b - Browse repository at this point
Copy the full SHA 81d0e8bView commit details -
Fix a case where AssignmentExpression is deeply nested
This commit also refactor `inConstructor` function from `prop-types` rule into `utils/Components` so that another rule could use that logic as well.
Configuration menu - View commit details
-
Copy full SHA for 3516a81 - Browse repository at this point
Copy the full SHA 3516a81View commit details -
Fix a case where left side of assignment is not MemberExpression
This commit also move `isStateMemberExpression` from `no-direct-mutation-state` rule into `util/Components` so that the logic could be share with other rules.
Configuration menu - View commit details
-
Copy full SHA for b1024c0 - Browse repository at this point
Copy the full SHA b1024c0View commit details
Commits on Oct 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b0e4c84 - Browse repository at this point
Copy the full SHA b0e4c84View commit details
Commits on Jan 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for acc35a1 - Browse repository at this point
Copy the full SHA acc35a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9415814 - Browse repository at this point
Copy the full SHA 9415814View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.