prop-types doesn't check nextProps of componentWillReceiveProps #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jan 20, 2018
lib/rules/prop-types.js
Outdated
| @@ -606,6 +606,10 @@ module.exports = { | |||
| type = 'destructuring'; | |||
| properties = node.params[0].properties; | |||
| break; | |||
| case 'MethodDefinition': | |||
| type = 'destructuring'; | |||
| properties = node.value.params[0].properties; | |||
There was a problem hiding this comment.
is there any chance a MethodDefinition could have a node without a value, or a node.value without a params, or a node.value.params without a 0th item?
it'd be ideal if this was more defensive (like you're already doing below), so the rule doesn't crash.
| ' }', | ||
| '}' | ||
| ].join('\n'), | ||
| parser: 'babel-eslint', |
There was a problem hiding this comment.
please add a duplicate test that uses the default parser
|
Thanks for the review @ljharb. I've pushed a new version of the fixes. |
ljharb
approved these changes
Jan 21, 2018
yannickcr
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1636.