Prevent jsx-no-bind crash #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule would assume a variable is initialized when checking a VariableDeclarator node.
|
Tested and works on my environment. |
ljharb
approved these changes
Nov 18, 2017
|
@yannickcr this, and #1545, should be released ASAP in a v7.5.1. |
|
Thanks for the quick fix! Although I'm not even sure how I got exposed to it 🤔 , considering that I have a eslint-plugin-react@^7.4.0:
version "7.4.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.4.0.tgz#300a95861b9729c087d362dd64abcc351a74364a"
dependencies:
doctrine "^2.0.0"
has "^1.0.1"
jsx-ast-utils "^2.0.0"
prop-types "^15.5.10" |
This was referenced Nov 19, 2017
|
Just ran into this and came to see if there was a fix. Sure enough, less than 24 hours ago! Looking forward to 7.5.1. Thanks @jomasti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule would assume a variable is initialized when checking a
VariableDeclarator node.
Fixes #1543