Fix no-unused-prop-types setState updater #1507
Conversation
| 'class MyComponent extends React.Component {', | ||
| ' onFoo() {', | ||
| ' this.setState((prevState, props) => {', | ||
| ' props.doSomething();', |
There was a problem hiding this comment.
does this work independent of what "props" is called?
There was a problem hiding this comment.
Not yet, working a better version that will handle more cases. This code doesn't handle destructuring or anything like that.
There was a problem hiding this comment.
I think it's important that it handles that from the get-go.
|
Does this case work with the prop-types rule? If not: the code is really similar and it should be possible to apply the same logic there. |
Handle when props are used in the setState update callback Fix jsx-eslint#1506
petersendidit
force-pushed
the
1506-fix
branch
from
bf498a2
to
c471d77
Compare
petersendidit
changed the title
|
Should handle this case much better now. Added a test case for when the second argument to the setState updater is not named |
|
What about the prop-types rule? Does it also need this functionality? |
|
Yes, I think it does. |
Handle when props are used in the setState update callback
Fix #1506