[Fix] forbid-prop-types: fix crash with propWrapper check on Member…

…Expressions Fixes #2104.
jsx-eslint · Jan 2, 2019 · e71feb5 · e71feb5
1 parent 11a66c0
commit e71feb5
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 7 deletions.
diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
@@ -125,7 +125,7 @@ module.exports = {
           break;
         case 'CallExpression':
           const innerNode = node.arguments && node.arguments[0];
-          if (propWrapperUtil.isPropWrapperFunction(context, node.callee.name) && innerNode) {
+          if (propWrapperUtil.isPropWrapperFunction(context, context.getSource(node.callee)) && innerNode) {
             checkNode(innerNode);
           }
           break;

diff --git a/tests/lib/rules/forbid-prop-types.js b/tests/lib/rules/forbid-prop-types.js
@@ -179,7 +179,7 @@ ruleTester.run('forbid-prop-types', rule, {
   }, {
     // Proptypes declared with a spread property
     code: [
-      'class Test extends react.component {',
+      'class Test extends React.component {',
       '  static propTypes = {',
       '    intl: React.propTypes.number,',
       '    ...propTypes',
@@ -190,7 +190,7 @@ ruleTester.run('forbid-prop-types', rule, {
   }, {
     // Proptypes declared with a spread property
     code: [
-      'class Test extends react.component {',
+      'class Test extends React.component {',
       '  static get propTypes() {',
       '    return {',
       '      intl: React.propTypes.number,',
@@ -351,7 +351,7 @@ ruleTester.run('forbid-prop-types', rule, {
   }, {
     // Proptypes declared with a spread property
     code: [
-      'class Test extends react.component {',
+      'class Test extends React.component {',
       '  static childContextTypes = {',
       '    intl: React.childContextTypes.number,',
       '    ...childContextTypes',
@@ -363,7 +363,7 @@ ruleTester.run('forbid-prop-types', rule, {
   }, {
     // Proptypes declared with a spread property
     code: [
-      'class Test extends react.component {',
+      'class Test extends React.component {',
       '  static get childContextTypes() {',
       '    return {',
       '      intl: React.childContextTypes.number,',
@@ -525,7 +525,7 @@ ruleTester.run('forbid-prop-types', rule, {
   }, {
     // Proptypes declared with a spread property
     code: [
-      'class Test extends react.component {',
+      'class Test extends React.component {',
       '  static childContextTypes = {',
       '    intl: React.childContextTypes.number,',
       '    ...childContextTypes',
@@ -537,7 +537,7 @@ ruleTester.run('forbid-prop-types', rule, {
   }, {
     // Proptypes declared with a spread property
     code: [
-      'class Test extends react.component {',
+      'class Test extends React.component {',
       '  static get childContextTypes() {',
       '    return {',
       '      intl: React.childContextTypes.number,',
@@ -547,6 +547,28 @@ ruleTester.run('forbid-prop-types', rule, {
       '}'
     ].join('\n'),
     options: [{checkChildContextTypes: true}]
+  }, {
+    code: [
+      'class TestComponent extends React.Component {',
+      '  static defaultProps = function () {',
+      '    const date = new Date();',
+      '    return {',
+      '      date',
+      '    };',
+      '  }();',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint'
+  }, {
+    code: [
+      'class HeroTeaserList extends React.Component {',
+      '  render() { return null; }',
+      '}',
+      'HeroTeaserList.propTypes = Object.assign({',
+      '  heroIndex: PropTypes.number,',
+      '  preview: PropTypes.bool,',
+      '}, componentApi, teaserListProps);'
+    ].join('\n')
   }],
 
   invalid: [{