[Fix] no-access-state-in-setstate: handle object spread

Fixes #1657
jsx-eslint · Jan 27, 2018 · e56376e · e56376e
1 parent d060041
commit e56376e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/rules/no-access-state-in-setstate.js b/lib/rules/no-access-state-in-setstate.js
@@ -148,7 +148,7 @@ module.exports = {
       ObjectPattern(node) {
         const isDerivedFromThis = node.parent.init && node.parent.init.type === 'ThisExpression';
         node.properties.forEach(property => {
-          if (property.key.name === 'state' && isDerivedFromThis) {
+          if (property && property.key && property.key.name === 'state' && isDerivedFromThis) {
             vars.push({
               node: property.key,
               scope: context.getScope(),

diff --git a/tests/lib/rules/no-access-state-in-setstate.js b/tests/lib/rules/no-access-state-in-setstate.js
@@ -12,8 +12,9 @@ const rule = require('../../../lib/rules/no-access-state-in-setstate');
 const RuleTester = require('eslint').RuleTester;
 
 const parserOptions = {
-  ecmaVersion: 6,
+  ecmaVersion: 2018,
   ecmaFeatures: {
+    experimentalObjectRestSpread: true,
     jsx: true
   }
 };
@@ -125,7 +126,7 @@ ruleTester.run('no-access-state-in-setstate', rule, {
     code: [
       'var Hello = React.createClass({',
       '  onClick: function() {',
-      '    var {state} = this',
+      '    var {state, ...rest} = this',
       '    this.setState({value: state.value + 1})',
       '  }',
       '});'