Fix direct props detection (fixes #298)

jsx-eslint · Nov 7, 2015 · d464347 · d464347
1 parent 004baae
commit d464347
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -327,7 +327,7 @@ module.exports = Components.detect(function(context, components) {
    * @return {string} the name of the property or undefined if not found
    */
   function getPropertyName(node) {
-    var isDirectProp = /^props\./.test(context.getSource(node));
+    var isDirectProp = /^props(\.|\[)/.test(context.getSource(node));
     var isInClassComponent = context.react.getParentES6Component() || context.react.getParentES5Component();
     var isNotInConstructor = !inConstructor(node);
     if (isDirectProp && isInClassComponent && isNotInConstructor) {
@@ -418,7 +418,7 @@ module.exports = Components.detect(function(context, components) {
           break;
         }
 
-        var isDirectProp = /^props\./.test(context.getSource(node));
+        var isDirectProp = /^props(\.|\[)/.test(context.getSource(node));
 
         usedPropTypes.push({
           name: name,

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -893,6 +893,17 @@ ruleTester.run('prop-types', rule, {
         '};'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      // Reassigned props are ignored
+      code: [
+        'export class Hello extends Component {',
+        '  render() {',
+        '    const props = this.props;',
+        '    return <div>Hello {props.name.firstname} {props[\'name\'].lastname}</div>',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],