[Fix] displayName (but really, propTypes detection): do not crash…

… on empty flow type spreads Fixes #2570.
jsx-eslint · Feb 8, 2020 · 66c0d66 · 66c0d66
1 parent 0a717a5
commit 66c0d66
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/util/ast.js b/lib/util/ast.js
@@ -168,6 +168,9 @@ function getKeyValue(context, node) {
   if (node.type === 'GenericTypeAnnotation') {
     return node.id.name;
   }
+  if (node.type === 'ObjectTypeAnnotation') {
+    return;
+  }
   const key = node.key || node.argument;
   return key.type === 'Identifier' ? key.name : key.value;
 }

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -482,6 +482,13 @@ ruleTester.run('display-name', rule, {
         return <div>{items}</div>;
       }
     `
+  }, {
+    code: `
+      import {Component} from "react";
+      type LinkProps = {...{}};
+      class Link extends Component<LinkProps> {}
+    `,
+    parser: parsers.BABEL_ESLINT
   }],
 
   invalid: [{