Fix void-dom-elements-no-children crash on faulty createElement detec…

…tion (fixes #1101)
jsx-eslint · May 9, 2017 · 605d9ac · 605d9ac
1 parent f111e45
commit 605d9ac
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/void-dom-elements-no-children.js b/lib/rules/void-dom-elements-no-children.js
@@ -98,7 +98,7 @@ module.exports = {
           return;
         }
 
-        if (!utils.hasDestructuredReactCreateElement() && !utils.isReactCreateElement(node)) {
+        if (!utils.isReactCreateElement(node)) {
           return;
         }
 

diff --git a/tests/lib/rules/void-dom-elements-no-children.js b/tests/lib/rules/void-dom-elements-no-children.js
@@ -67,6 +67,18 @@ ruleTester.run('void-dom-elements-no-children', rule, {
         'createElement("img")'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'import React, {createElement, PureComponent} from \'react\';',
+        'class Button extends PureComponent {',
+        '  handleClick = ev => {',
+        '    ev.preventDefault();',
+        '  }',
+        '  render() {',
+        '    return <div onClick={this.handleClick}>Hello</div>;',
+        '  }'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],
   invalid: [