[Fix] Ignore reassignments when matching props declarations with comp…

…onents Fixes #2051 Fixes #1957
jsx-eslint · Jan 6, 2019 · 5fc50aa · 5fc50aa
1 parent ba80a4c
commit 5fc50aa
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -567,7 +567,7 @@ function componentRule(rule, context) {
         }
         if (refId.type === 'MemberExpression') {
           componentNode = refId.parent.right;
-        } else if (refId.parent && refId.parent.type === 'VariableDeclarator') {
+        } else if (refId.parent && refId.parent.type === 'VariableDeclarator' && refId.parent.init.type !== 'Identifier') {
           componentNode = refId.parent.init;
         }
         break;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2277,6 +2277,25 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: `
+        import React from 'react';
+        import PropTypes from 'prop-types';
+        import {connect} from 'react-redux';
+
+        class Foo extends React.Component {
+          render() {
+            return this.props.children;
+          }
+        }
+
+        Foo.propTypes = {
+          children: PropTypes.element.isRequired
+        };
+
+        export const Unconnected = Foo;
+        export default connect(Foo);
+      `
     }
   ],