-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ESLint to v6 #603
Merged
Merged
Update ESLint to v6 #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebeach
force-pushed
the
another-attempt-at-eslint-v6
branch
3 times, most recently
from
June 23, 2019 20:14
7205183
to
22053a7
Compare
jessebeach
changed the title
Update ESLint to v6
Update ESLint to v6, keep ESLint V3 peer dependency
Jun 23, 2019
ljharb
reviewed
Jun 23, 2019
jessebeach
force-pushed
the
another-attempt-at-eslint-v6
branch
6 times, most recently
from
June 23, 2019 22:09
5c57815
to
b07d8ec
Compare
ljharb
approved these changes
Jun 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be blocked on import-js/eslint-plugin-import#1393
jessebeach
changed the title
Update ESLint to v6, keep ESLint V3 peer dependency
Update ESLint to v6
Jun 23, 2019
@ljharb ok, I think this is it. Just blocked on airbnb/javascript#2036 |
17 tasks
@jessebeach try with v2.18.0 of the import plugin. |
jessebeach
force-pushed
the
another-attempt-at-eslint-v6
branch
2 times, most recently
from
June 26, 2019 04:31
8021da5
to
91f17be
Compare
That worked!
…On Mon, Jun 24, 2019 at 2:53 PM Jordan Harband ***@***.***> wrote:
@jessebeach <https://github.com/jessebeach> try with v2.18.0 of the
import plugin.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/evcohen/eslint-plugin-jsx-a11y/pull/603?email_source=notifications&email_token=AACUOOMNP53ITZR4WXIRYHLP4E66HA5CNFSM4H2ZVMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYOK5UA#issuecomment-505196240>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACUOOKBXI3MHWVBIFEES3LP4E66HANCNFSM4H2ZVMYQ>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try just the addition of v6.
(ref #602)