Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implicitRoles/select.js: implicit role is now "combobox" #949

Closed
kantoche opened this issue Aug 17, 2023 · 1 comment · Fixed by #1027
Closed

implicitRoles/select.js: implicit role is now "combobox" #949

kantoche opened this issue Aug 17, 2023 · 1 comment · Fixed by #1027
Assignees
@jessebeach

Comments

@kantoche
Copy link

kantoche commented Aug 17, 2023 •
edited
Loading

Hi,

With the Aria 1.2 update, the implicit role of select element is now "combobox".
@kantoche kantoche changed the title /implicitRoles /select.js $ /implicitRoles /select.js: implicit role is now "combobox" Aug 17, 2023
@kantoche kantoche changed the title /implicitRoles /select.js: implicit role is now "combobox" implicitRoles/select.js: implicit role is now "combobox" Aug 17, 2023
lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 23, 2024
@lb-
[fix] Refine implicit role of select to include combobox scenarios
94f3e3f 
Encode implicit roles for `select` elements based on roles defined in https://www.w3.org/TR/html-aria/#el-select

- `select` (with a multiple attribute or a size attribute having value greater than 1) will have the implicit role 'listbox'
- `select` (with NO multiple attribute and NO size attribute having value greater than 1) will have the implicit role 'combobox'

Fixes jsx-eslint#949
@lb- lb- mentioned this issue Oct 23, 2024
Merged
@lb-
Copy link
Contributor

lb- commented Oct 23, 2024

PR up with a change to support this, note that it's a bit more nuanced where listbox or combobox can be valid based on the attributes. Because... it would be boring otherwise :D

#1027

https://www.w3.org/TR/html-aria/#el-select

lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 23, 2024
@lb-
[fix] Refine implicit role of select to include combobox scenarios
c1e47c1 
Encode implicit roles for `select` elements based on roles defined in https://www.w3.org/TR/html-aria/#el-select

- `select` (with a multiple attribute or a size attribute having value greater than 1) will have the implicit role 'listbox'
- `select` (with NO multiple attribute and NO size attribute having value greater than 1) will have the implicit role 'combobox'

Fixes jsx-eslint#949
lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 26, 2024
@lb-
[fix] Refine implicit role of select to include combobox scenarios
bdc1cf4 
Encode implicit roles for `select` elements based on roles defined in https://www.w3.org/TR/html-aria/#el-select

- `select` (with a multiple attribute or a size attribute having value greater than 1) will have the implicit role 'listbox'
- `select` (with NO multiple attribute and NO size attribute having value greater than 1) will have the implicit role 'combobox'

Fixes jsx-eslint#949
lb- added a commit to lb-/eslint-plugin-jsx-a11y that referenced this issue Oct 27, 2024
@lb-
[fix] Refine implicit role of select to include combobox scenarios
59f4396 
Encode implicit roles for `select` elements based on roles defined in https://www.w3.org/TR/html-aria/#el-select

- `select` (with a multiple attribute or a size attribute having value greater than 1) will have the implicit role 'listbox'
- `select` (with NO multiple attribute and NO size attribute having value greater than 1) will have the implicit role 'combobox'

Fixes jsx-eslint#949
@ljharb ljharb closed this as completed in d13725d Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessebeach jessebeach

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jessebeach @lb- @kantoche