Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unblock more events #50

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

ktully
Copy link

@ktully ktully commented Mar 11, 2018

Unblock copy and paste on more sites, and unblock cut in general

  • Add cut to the list of events which can be unblocked

  • Unblock on sites which capture Ctrl key or right-click events

  • Unblock accessing the context menu

  • Unblock selecting text to copy when outside form inputs

  • Add tests for all the above

  • Fix some intellij JS warnings

  • Rename some functions - possibly controversial :)

The new unblockings will probably break some sites with rich content editors, necessitating more use of the site whitelist/blacklist by users.

@ktully
Copy link
Author

ktully commented Mar 11, 2018

May resolve #47 as a side-effect

@ktully
Copy link
Author

ktully commented Mar 14, 2018

@jswanner if I resolve the conflicts with your 2.0 updates (and follow the new pattern for deregistering event handlers when the extension is deactivated), is this a merge request you're likely to accept?

How do you feel about me renaming allowCopyAndPaste() in content.js?

@jswanner
Copy link
Owner

@ktully firstly, thanks for caring enough to make the changes and the PR.

I've been debating with myself over how I feel about these changes -- with the exception of cut events, which I should have thought about when I accepted the PR that added copy events.

I certainly would not have wanted to merge this with version 1, since with the default configuration those event handlers would have run on the majority of pages, causing far more harm than good. Now that I've released v2 (setting aside the negative feedback), I'm more open to the idea of the extension intercepting these additional events.

@jswanner
Copy link
Owner

How do you feel about me renaming allowCopyAndPaste() in content.js?

I'm fine with it being renamed, but I would probably call it something along the lines of forceBrowserDefault.

@nitrocode
Copy link

@ktully Why is your fork DontMessWithPaste instead of DontFuckWithPaste ?

😞 that you removed the emotional expletive that increases our satisfaction to use this addon

@kwaaak
Copy link

kwaaak commented Apr 11, 2018

https://www.cloudbet.com/ also blocks pasting into their "Stake" input fields. If someone has the leisure, you could go through https://www.cloudbet.com/public/js/desktop_cecc931.js and figure out how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants