Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (service): add respect for fallback language for translateObject #583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jensweigele
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

selectTranslateObject and translateObject are not falling back to the fallback language.

Issue Number: N/A

What is the new behavior?

If the result object is empty, the translateObject is called with the fallback language.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@jensweigele
Copy link
Contributor Author

This PR fixes #519

@sithwarrior
Copy link

Really hate to tag people but @shaharkazaz could someone look into merging this?

Seems like @jensweigele has done a great job at making this a small change. Really need the fallback language feature to work for our project setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants