Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transloco): 🐛 Add generic type default to Translate<T>() #545

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

seadonk
Copy link
Contributor

@seadonk seadonk commented Jan 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Translate function is generically typed as unknown by default.
This causes type errors including:

Argument of type 'unknown' is not assignable to parameter of type 'string'

Issue Number: #544

What is the new behavior?

Translate function is generically typed as string by default.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@seadonk
Copy link
Contributor Author

seadonk commented Feb 15, 2022

@shaharkazaz Sorry, accidentally closed the PR, then reopened it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants