Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstz_crypto): get hash of public keys #723

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

huancheng-trili
Copy link
Collaborator

Context

Part of JSTZ-247.
JSTZ-247

In preparation for #721.

Description

Get public key hashes from public keys.

Manually testing the PR

  • Unit testing: added one test

@huancheng-trili huancheng-trili marked this pull request as ready for review December 30, 2024 12:50
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-247-1 branch from 2295cb7 to 2770eb8 Compare December 31, 2024 17:43
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-247-2 branch from fd80348 to c47fc90 Compare December 31, 2024 17:44
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.93%. Comparing base (402aa9b) to head (7df151a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstz_crypto/src/public_key.rs 95.23% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstz_crypto/src/public_key.rs 54.31% <95.23%> (+9.51%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402aa9b...7df151a. Read the comment docs.

Base automatically changed from huanchengchang-jstz-247-1 to main January 2, 2025 17:07
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-247-2 branch from c47fc90 to 7df151a Compare January 2, 2025 17:10
@huancheng-trili huancheng-trili merged commit 8b2b140 into main Jan 2, 2025
3 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-247-2 branch January 2, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants