Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(octez): store bootstrap accounts in protocol parameters #719

Open
wants to merge 1 commit into
base: huanchengchang-jstz-247-2
Choose a base branch
from

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Dec 20, 2024

Context

Part of JSTZ-247.
JSTZ-247

In preparation for #721.

Description

Store bootstrap accounts in protocol parameters so that they can be retrieved later.

Manually testing the PR

  • Unit testing: added one test

@huancheng-trili huancheng-trili marked this pull request as ready for review December 20, 2024 16:32
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.24%. Comparing base (fd80348) to head (3dadcd4).

Files with missing lines Patch % Lines
crates/octez/src/async/protocol.rs 95.23% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/octez/src/async/bootstrap.rs 90.47% <ø> (ø)
crates/octez/src/async/protocol.rs 94.47% <95.23%> (+0.15%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd80348...3dadcd4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants