Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(octez): write baker log to file #714

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

huancheng-trili
Copy link
Collaborator

Context

Part of JSTZ-244.
JSTZ-244.

Description

Write baker logs to a log file instead of stdout/stderr.

Manually testing the PR

Ran jstzd locally and did not see any baker logs.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.23%. Comparing base (60a8fe0) to head (e37df5b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/octez/src/async/baker.rs 87.50% 0 Missing and 3 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/config.rs 97.19% <100.00%> (+0.02%) ⬆️
crates/octez/src/async/baker.rs 93.33% <87.50%> (+4.51%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a8fe0...e37df5b. Read the comment docs.

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-244-4-1 branch from 50c56ba to 95d2674 Compare December 19, 2024 13:35
@huancheng-trili huancheng-trili marked this pull request as ready for review December 20, 2024 16:31
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-244-4 branch from 89b2c0c to f15bf88 Compare December 30, 2024 13:00
Base automatically changed from huanchengchang-jstz-244-4 to main December 31, 2024 16:36
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-244-4-1 branch from 95d2674 to e37df5b Compare December 31, 2024 16:38
@huancheng-trili huancheng-trili merged commit 7d9510d into main Dec 31, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-244-4-1 branch December 31, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants