Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leounoki jstz 242/serialize jstz node config #706

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

ryutamago
Copy link
Collaborator

Context

serialize node config

Description

serialize the node config

Manually testing the PR

unit test
integratio for jstzd test

@ryutamago ryutamago force-pushed the leounoki-jstz-242/serialize-jstz-node-config branch from c800041 to 9b22453 Compare December 6, 2024 12:15
@ryutamago ryutamago marked this pull request as ready for review December 6, 2024 12:19
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.20%. Comparing base (966fbc6) to head (c9ef77f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/octez/src/async/rollup.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstz_node/src/config.rs 100.00% <100.00%> (ø)
crates/jstzd/src/task/jstzd.rs 75.08% <ø> (ø)
crates/octez/src/async/rollup.rs 95.81% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966fbc6...c9ef77f. Read the comment docs.

@ryutamago ryutamago force-pushed the leounoki-jstz-241/serialize-rollup-config branch 2 times, most recently from 005b0e2 to 909db37 Compare December 6, 2024 14:49
@ryutamago ryutamago force-pushed the leounoki-jstz-242/serialize-jstz-node-config branch from 9b22453 to ab1c0fb Compare December 6, 2024 14:50
Base automatically changed from leounoki-jstz-241/serialize-rollup-config to main December 6, 2024 15:51
@ryutamago ryutamago force-pushed the leounoki-jstz-242/serialize-jstz-node-config branch from ab1c0fb to c9ef77f Compare December 6, 2024 15:52
@ryutamago ryutamago enabled auto-merge (rebase) December 6, 2024 15:52
@ryutamago ryutamago merged commit 8330a51 into main Dec 6, 2024
3 checks passed
@ryutamago ryutamago deleted the leounoki-jstz-242/serialize-jstz-node-config branch December 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants