Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jstzd: serialize rollup config #705

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Dec 6, 2024

Context

serialzie rollup config

Description

serialize the rollup config and return as part of the config endpoint

Manually testing the PR

add integration test to jstzd
add unit test

@ryutamago ryutamago changed the base branch from main to leounoki-jstz-240/jstz-node-config December 6, 2024 10:33
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.16%. Comparing base (4fed084) to head (909db37).
Report is 1 commits behind head on main.

Files with missing lines Coverage Δ
crates/jstzd/src/task/jstzd.rs 75.08% <ø> (ø)
crates/octez/src/async/rollup.rs 95.81% <100.00%> (+0.81%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fed084...909db37. Read the comment docs.

@ryutamago ryutamago force-pushed the leounoki-jstz-241/serialize-rollup-config branch from 2514ac2 to b66f61b Compare December 6, 2024 12:14
@ryutamago ryutamago changed the title Leounoki jstz 241/serialize rollup config Jstzd: serialize rollup config Dec 6, 2024
@ryutamago ryutamago marked this pull request as ready for review December 6, 2024 12:19
crates/octez/src/async/rollup.rs Outdated Show resolved Hide resolved
Base automatically changed from leounoki-jstz-240/jstz-node-config to main December 6, 2024 14:21
@ryutamago ryutamago force-pushed the leounoki-jstz-241/serialize-rollup-config branch from b66f61b to 005b0e2 Compare December 6, 2024 14:47
@ryutamago ryutamago force-pushed the leounoki-jstz-241/serialize-rollup-config branch from 005b0e2 to 909db37 Compare December 6, 2024 14:49
@ryutamago ryutamago merged commit 966fbc6 into main Dec 6, 2024
5 checks passed
@ryutamago ryutamago deleted the leounoki-jstz-241/serialize-rollup-config branch December 6, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants