Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jstzd: spawn node in jstzd server #701

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ryutamago
Copy link
Collaborator

Context

task

The ci fails for the same reason as the rollup PR

Description

  • spawn jstz-node in jstzd
  • introduce a type aliass Shared and refactored the jstzd by adding a blanket implementation so we can avoid having to write Arc<RwLock<.. everywhere

Manually testing the PR

add integration tests the runs successfully locally

nix flake check

@ryutamago ryutamago force-pushed the leounoki-jstz-165/spawn-jstz-node-3 branch from aba6132 to cfceb97 Compare December 4, 2024 11:10
@ryutamago ryutamago marked this pull request as ready for review December 4, 2024 11:11
@ryutamago ryutamago changed the title Leounoki jstz 165/spawn jstz node 3 Jstzd: spawn node in jstzd server Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.04%. Comparing base (a013349) to head (cfceb97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/task/jstzd.rs 75.00% 1 Missing and 6 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/config.rs 96.85% <100.00%> (+0.06%) ⬆️
crates/jstzd/src/task/child_wrapper.rs 93.33% <ø> (ø)
crates/jstzd/src/task/jstzd.rs 77.48% <75.00%> (+1.42%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a013349...cfceb97. Read the comment docs.

Copy link
Collaborator

@huancheng-trili huancheng-trili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but please keep code refactoring in separate PRs and do not refactor while the part of the code base involved is being actively worked on.

@ryutamago ryutamago merged commit 254701e into main Dec 4, 2024
5 checks passed
@ryutamago ryutamago deleted the leounoki-jstz-165/spawn-jstz-node-3 branch December 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants