Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jstzd): use protocol version from proto params #700

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

huancheng-trili
Copy link
Collaborator

Context

If baker path is not provided in user config, jstzd should fall back to the default baker path according to the target protocol version. If protocol version is specified in user config, that protocol version should be referenced by the baker config builder. The bug is that it still defaults to alpha when protocol version is provided in user config.

Description

Fixes the bug by checking the protocol version provided during baker config population.

Manually testing the PR

  • Unit test: updated one test case
  • Manual test: launched the sandbox locally and confirmed that this was fixed

@huancheng-trili huancheng-trili force-pushed the huan/baker-proto-version branch from 18b1635 to 64c7b67 Compare December 4, 2024 09:41
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.30%. Comparing base (8330a51) to head (8b70f68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/config.rs 97.77% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/config.rs 96.93% <97.77%> (+0.41%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8330a51...8b70f68. Read the comment docs.

@huancheng-trili huancheng-trili marked this pull request as ready for review December 4, 2024 10:06
Base automatically changed from huan/pack-bootstrap-contract to main December 4, 2024 17:34
@huancheng-trili huancheng-trili force-pushed the huan/baker-proto-version branch from 64c7b67 to e9170e0 Compare December 6, 2024 11:34
Copy link
Collaborator

@ryutamago ryutamago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@huancheng-trili huancheng-trili force-pushed the huan/baker-proto-version branch from e9170e0 to 8b70f68 Compare December 6, 2024 16:36
@huancheng-trili huancheng-trili merged commit 26bec48 into main Dec 6, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huan/baker-proto-version branch December 6, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants