Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): implement jstzd cli #689

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

huancheng-trili
Copy link
Collaborator

Context

Part of JSTZ-168.

JSTZ-168

Description

Implements jstzd run <config_path>.

crates/jstzd/tests/dummy.rs is removed because it has one dummy case that calls the revised main function and I didn't bother updating that.

Manually testing the PR

  • Integration test: added new tests
$ cargo test --test main_test

running 4 tests
test unknown_command ... ok
test bad_config_file ... ok
test valid_config_file ... ok
test default_config ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

@huancheng-trili huancheng-trili marked this pull request as ready for review November 25, 2024 16:56
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.73%. Comparing base (4be32b4) to head (bb610b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/lib.rs 90.90% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/config.rs 96.70% <100.00%> (+0.23%) ⬆️
crates/jstzd/src/main.rs 100.00% <100.00%> (+100.00%) ⬆️
crates/jstzd/src/lib.rs 91.66% <90.90%> (-8.34%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be32b4...bb610b7. Read the comment docs.

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-9 branch from d054009 to 0fbc41e Compare November 27, 2024 14:37
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-8 branch from b79b8e9 to 92a578e Compare November 29, 2024 09:38
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-9 branch from 0fbc41e to efd416c Compare November 29, 2024 09:39
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-8 branch from 92a578e to 3748079 Compare November 29, 2024 13:41
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-9 branch from efd416c to da0470e Compare November 29, 2024 13:42
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-8 branch from 3748079 to 3e03410 Compare November 29, 2024 15:39
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-9 branch from da0470e to dcddb24 Compare November 29, 2024 15:40
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-8 branch from 3e03410 to 9c2a4a5 Compare November 29, 2024 15:50
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-9 branch from dcddb24 to 6e2db30 Compare November 29, 2024 15:51
@zcabter zcabter self-requested a review December 2, 2024 11:56
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-8 branch from 9c2a4a5 to 54ce88f Compare December 2, 2024 14:47
Base automatically changed from huanchengchang-jstz-168-8 to main December 2, 2024 15:08
@huancheng-trili huancheng-trili requested review from fizikarubi and removed request for fizikarubi December 2, 2024 16:15
@huancheng-trili huancheng-trili merged commit e245e13 into main Dec 2, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-168-9 branch December 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants