Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): insert jstz bootstrap contracts #684

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

huancheng-trili
Copy link
Collaborator

Context

Part of JSTZ-168.

JSTZ-168

Description

Insert jstz smart contracts into user config.

Note that user contracts whose addresses collide with those reserved for jstz contracts will overwrite jstz contracts. This aligns with the current implementation where bootstrap contracts in the base parameter file take precedence, even if it means that jstz won't launch in such cases.

Manually testing the PR

  • Unit test: added test cases

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 94.15584% with 9 lines in your changes missing coverage. Please review.

Project coverage is 47.60%. Comparing base (4a237bb) to head (f5fbf93).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstzd/src/config.rs 95.86% 0 Missing and 6 partials ⚠️
crates/octez/src/async/bootstrap.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/lib.rs 100.00% <ø> (ø)
crates/octez/src/async/protocol.rs 94.16% <100.00%> (+0.05%) ⬆️
crates/octez/src/async/bootstrap.rs 89.88% <0.00%> (-0.54%) ⬇️
crates/jstzd/src/config.rs 96.46% <95.86%> (+0.30%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a237bb...f5fbf93. Read the comment docs.

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-7 branch 2 times, most recently from ed89ae9 to 05b4280 Compare November 22, 2024 14:58
@huancheng-trili huancheng-trili marked this pull request as ready for review November 26, 2024 15:46
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-6 branch from 8b39401 to f4482c7 Compare November 29, 2024 09:28
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-7 branch from 05b4280 to bf1e11c Compare November 29, 2024 09:29
Base automatically changed from huanchengchang-jstz-168-6 to main November 29, 2024 13:39
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-7 branch from bf1e11c to 0857f6f Compare November 29, 2024 13:40
Copy link
Collaborator

@ryutamago ryutamago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-168-7 branch from 0857f6f to f5fbf93 Compare November 29, 2024 15:38
@huancheng-trili huancheng-trili merged commit 646ba92 into main Nov 29, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-168-7 branch November 29, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants