Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstz_engine): add support for rooting GC values #680

Open
wants to merge 1 commit into
base: ajob410@jstz-195-tracing
Choose a base branch
from

Conversation

johnyob
Copy link
Collaborator

@johnyob johnyob commented Nov 20, 2024

Context

See gc/root.rs for context.

Description

See gc/root.rs for described solution.

Manually testing the PR

cargo nextest run -p jstz_engine

@johnyob johnyob self-assigned this Nov 20, 2024
@johnyob johnyob force-pushed the ajob410@jstz-195-tracing branch 2 times, most recently from 25ee901 to f55488f Compare November 27, 2024 18:32
@johnyob johnyob force-pushed the ajob410@jstz-196-rooting branch from 4f665fa to 6146f87 Compare November 27, 2024 19:52
@johnyob johnyob requested a review from zcabter November 27, 2024 19:53
@johnyob johnyob marked this pull request as ready for review November 27, 2024 19:53
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 61.96078% with 97 lines in your changes missing coverage. Please review.

Please upload report for BASE (ajob410@jstz-195-tracing@925a0c6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/jstz_engine/src/gc/root.rs 71.15% 45 Missing ⚠️
crates/jstz_engine/src/script.rs 25.00% 36 Missing ⚠️
crates/jstz_engine/src/realm.rs 33.33% 10 Missing ⚠️
crates/jstz_engine/src/context.rs 83.33% 6 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstz_engine/src/gc/ptr.rs 66.15% <ø> (ø)
crates/jstz_engine/src/context.rs 74.82% <83.33%> (ø)
crates/jstz_engine/src/realm.rs 60.00% <33.33%> (ø)
crates/jstz_engine/src/script.rs 23.84% <25.00%> (ø)
crates/jstz_engine/src/gc/root.rs 71.15% <71.15%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925a0c6...f08a53d. Read the comment docs.

@johnyob johnyob assigned zcabter and unassigned johnyob Nov 27, 2024
@johnyob johnyob force-pushed the ajob410@jstz-195-tracing branch from f55488f to dd196ea Compare December 11, 2024 14:30
@johnyob johnyob force-pushed the ajob410@jstz-196-rooting branch from 6146f87 to 23c099b Compare December 11, 2024 14:30
@johnyob johnyob force-pushed the ajob410@jstz-195-tracing branch 2 times, most recently from 174b36c to 925a0c6 Compare December 20, 2024 14:47
@johnyob johnyob force-pushed the ajob410@jstz-196-rooting branch from 23c099b to f08a53d Compare December 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants