Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(octez): serialise directory #668

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Nov 15, 2024

Context

Part of JSTZ-121; in preparation for #655.

JSTZ-121

Description

Serialise directory.

Manually testing the PR

  • Unit test: added new test cases

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.59%. Comparing base (bf1af2d) to head (7d75dc5).
Report is 1 commits behind head on main.

Files with missing lines Coverage Δ
crates/octez/src/async/directory.rs 97.16% <100.00%> (+1.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf1af2d...7d75dc5. Read the comment docs.


🚨 Try these New Features:

@huancheng-trili huancheng-trili marked this pull request as ready for review November 15, 2024 16:31
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-121-4 branch from 0f4c4e2 to c8fe939 Compare November 15, 2024 17:36
Base automatically changed from huanchengchang-jstz-121-4 to main November 19, 2024 13:23
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-121-4-1 branch from eaa9af1 to 87a0da1 Compare November 20, 2024 09:34
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-121-4-1 branch from 87a0da1 to 7d75dc5 Compare November 20, 2024 14:23
@huancheng-trili huancheng-trili changed the title feat(octez): serialise octez client config feat(octez): serialise directory Nov 20, 2024
@zcabter zcabter assigned huancheng-trili and unassigned zcabter Nov 20, 2024
@huancheng-trili huancheng-trili merged commit 24324a0 into main Nov 21, 2024
5 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-121-4-1 branch November 21, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants