-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jstz_engine): implement a write-barriered GC pointer abstraction #661
Conversation
0a803c7
to
a694770
Compare
f480385
to
e660d95
Compare
a694770
to
9106c11
Compare
e911862
to
96d3d75
Compare
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
9106c11
to
7cbd91a
Compare
96d3d75
to
94ddd2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates, LGTM otherwise.
6a9c971
to
d874eaf
Compare
Context
Problem: SpiderMonkey has an incremental garbage collector that relies on write barriers to maintain a consistency reachability set.
Intuitive view of incremental GC:
...
However, in step 3, the reachability set of objects may change. Write barriers are a solution to notify the GC when the reachability set might change e.g. on a write to a pointer.
Description
This PR implements
GcPtr
, a safe write barriered pointer.Dereferencing the pointer is still unsafe since the caller must guarentee that the object that the
pointer points to is valid.
Manually testing the PR