feat(jstzd): define Task trait #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
|
zcabter
reviewed
Sep 13, 2024
Cargo.toml
Outdated
Comment on lines
15
to
16
| "crates/octez", | ||
| "crates/jstzd" |
There was a problem hiding this comment.
Nit: Alphabetical ordering
Suggested change
| "crates/octez", | |
| "crates/jstzd" | |
| "crates/jstzd" | |
| "crates/octez", |
crates/jstzd/Cargo.toml
Outdated
Comment on lines
11
to
14
| async-dropper = { version = "0.3.1", features = ["tokio", "simple"] } | ||
| async-trait = "0.1.82" | ||
| futures-util.workspace = true | ||
| async-scoped = "0.9.0" |
There was a problem hiding this comment.
Nit: Move dependencies to workspace Cargo
crates/jstzd/src/task/mod.rs
Outdated
| #[async_trait] | ||
| trait Task { | ||
| type Config; | ||
| async fn spawn(config: Self::Config) -> anyhow::Result<Self> |
There was a problem hiding this comment.
Lets just use anyhow::Result
huancheng-trili
force-pushed
the
huan/jstzd-define-task-trait
branch
from
b21a887 to
7aae0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Define the Task trait. Task represents any task to be run with backends, e.g. octez node, jstz node, etc.
JSTZ-115
Description
Define the basic
Tasktrait.The methods:
spawn: The initialiser that takes in the necessary config for this task and runs the task.kill: Abort the running task.health_check: Check if the task is still alive.Manually testing the PR
cargo build