Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(account): rename deposit to add balance and add overflow check #549

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

zcabter
Copy link
Collaborator

@zcabter zcabter commented Aug 29, 2024

Context

This PR makes small changes to Account deposit mainly for consistency and safety:

  • renames deposit to add_balance
  • adds overflow check to add_balance

Description

Manually testing the PR

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.34%. Comparing base (6155f07) to head (8e6a2d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstz_proto/src/context/account.rs 83.33% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/jstz_proto/src/executor/deposit.rs 100.00% <100.00%> (ø)
crates/jstz_proto/src/context/account.rs 60.71% <83.33%> (+0.34%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6155f07...8e6a2d8. Read the comment docs.

Copy link
Collaborator

@johnyob johnyob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnyob johnyob assigned zcabter and unassigned johnyob Aug 29, 2024
@zcabter zcabter assigned johnyob and unassigned zcabter Aug 29, 2024
@zcabter zcabter merged commit c8fcaed into main Aug 29, 2024
5 checks passed
@zcabter zcabter deleted the ryan-jstz-79 branch August 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants