Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use nix flake for environment #544

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

johnyob
Copy link
Collaborator

@johnyob johnyob commented Aug 15, 2024

Context

Related Tasks: jstz-66

Description

Dependencies: #543 #542

Does what it says on the tin.

Future work includes:

  • Building docs using Nix
  • Linting Rust code using Nix (currently we rely on make lint which will pull its own dependencies)
  • Using self-hosted runners for better cache locality + exposing the cache to devs (for local environments). magic-nix-cache isn't very good and will often drop cached dependencies in favour of space

Manually testing the PR

Green CI 🚀

@johnyob johnyob requested a review from zcabter August 15, 2024 14:43
@johnyob johnyob force-pushed the ajob410@ci/jstz-45-nixing-support branch from 949544c to 6985d84 Compare August 15, 2024 14:48
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from 1364a1b to 5a1894b Compare August 15, 2024 14:49
@johnyob johnyob force-pushed the ajob410@ci/jstz-45-nixing-support branch from 6985d84 to 57120bb Compare August 15, 2024 14:51
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from 5a1894b to 2b20d48 Compare August 15, 2024 14:52
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from f658c81 to 8fe18ef Compare August 15, 2024 17:24
@johnyob johnyob changed the title ci: use nix flake for environment [DO NOT MERGE] ci: use nix flake for environment Aug 16, 2024
@johnyob johnyob force-pushed the ajob410@ci/jstz-45-nixing-support branch from 57120bb to ee3a3a5 Compare August 21, 2024 14:06
@johnyob johnyob changed the base branch from ajob410@ci/jstz-45-nixing-support to main August 21, 2024 14:10
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from 76de5bc to 4754658 Compare August 21, 2024 14:12
@johnyob johnyob changed the title [DO NOT MERGE] ci: use nix flake for environment ci: use nix flake for environment Aug 22, 2024
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch 2 times, most recently from 07d4ea6 to d2725e0 Compare August 22, 2024 14:51
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.33%. Comparing base (48d8056) to head (29ca3e8).
Report is 1 commits behind head on main.

see 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d8056...29ca3e8. Read the comment docs.

@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from d2725e0 to 0f14e1f Compare August 22, 2024 15:33
@johnyob johnyob changed the base branch from main to ajob410@ci/jstz-45-nixing-support August 22, 2024 15:33
@johnyob johnyob changed the title ci: use nix flake for environment [DO NOT MERGE] ci: use nix flake for environment Aug 22, 2024
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from 0f14e1f to f571f86 Compare August 22, 2024 16:25
Base automatically changed from ajob410@ci/jstz-45-nixing-support to main August 22, 2024 16:55
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from f571f86 to c48c936 Compare August 23, 2024 10:38
@johnyob johnyob force-pushed the ajob410@ci/jstz-66-nix-ci branch from c48c936 to 29ca3e8 Compare August 23, 2024 10:39
@johnyob johnyob changed the title [DO NOT MERGE] ci: use nix flake for environment ci: use nix flake for environment Aug 27, 2024
Copy link
Collaborator

@zcabter zcabter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green ci, lgtm!

@zcabter zcabter assigned johnyob and unassigned zcabter Aug 28, 2024
@johnyob johnyob merged commit 6155f07 into main Aug 28, 2024
5 checks passed
@johnyob johnyob deleted the ajob410@ci/jstz-66-nix-ci branch August 28, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants