Allow easier implementation of IX509CertificateDatabase and BouncyCastleSecureMimeContext #1111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing IX509CertificateDatabase and extending BouncyCastleSecureMimeContext I ran into a few internal methods I would like to use for consistency. This PR exposes those with code documentation.
I chose this crypto-abstratctions branch because I thought it might be the appropriate place but I could change the PR to the main branch if my changes are acceptable.
I have more PRs. I just want to ensure they are something you are OK with.
Future PR themes I have ready are:
I have a test harness localy where I have ensured I could wrap, sign and encrypt witht he Direct Project reference implementation and the Decrypt with MimeKit and the reverse. In my more modern offline version we use MimeKit heavily for but there is a lot of tranlation between MimeKit and our Direct Project implementation of Mime. This experiment shows me that we could adopt MimeKit as our SMIME api and save a lot in allocations.
Thanks for reading this far and of course thanks for one of the best c# OS contributions.
-- Joe