Add a Docker container as an option to run the program #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the benefit of being able to easily run on any Linux system with Docker and FUSE with no system-wide installation. (Tested on Pop!_OS and OpenSUSE Tumbleweed)
It should theoretically even work on Mac with MacFUSE but this is untested.
If it is decided that Docker is to be integrated as an official target for the project, some improvements and optimizations could definitely be made for easier use and more optimal images. As is, this is a working proof of concept and a mildly useful addition. If someone wants to try it as is, one can (after cloning the repo) run the included
docker-run.sh.Publishing on the Docker Hub would make the Docker option far easier to use as building the image every time would not be required anymore. This could be fairly easily implemented with a GitHub Actions workflow. The image could be optimized further by e.g. splitting into a build stage and run stage. I would be happy to work on these improvements if the Docker option is to be included in the main project.