Skip to content

Commit

Permalink
FOG_NEAR to FOG_NEAR_DISTANCE, minimum of 1%
Browse files Browse the repository at this point in the history
0% resulted in extreme white and some colors inverting
  • Loading branch information
jss2a98aj committed May 11, 2024
1 parent 8465676 commit 369d636
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/main/java/jss/notfine/core/Settings.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public void applyChanges() {
}
},
DYNAMIC_FOV(new NotFineOptionTickBox(true, null)),
FOG_NEAR_DISTANCE(new NotFineOptionSliderPercentage(75, 1, 100, 1, OptionImpact.LOW)),
GUI_BACKGROUND(new NotFineOptionCycling<>(BackgroundSelect.DEFAULT, null)) {
@Override
public void applyChanges() {
Expand Down Expand Up @@ -114,8 +115,7 @@ public void applyChanges() {
RenderStars.reloadStarRenderList(Minecraft.getMinecraft().renderGlobal);
}
},
VOID_FOG(new NotFineOptionTickBox(false, OptionImpact.LOW)),
FOG_NEAR(new NotFineOptionSliderPercentage(75, 0, 100, 1, OptionImpact.LOW));
VOID_FOG(new NotFineOptionTickBox(false, OptionImpact.LOW));

public final NotFineOption option;

Expand Down Expand Up @@ -185,7 +185,7 @@ public static class NotFineOptionSliderPercentage extends NotFineOptionSlider {
protected NotFineOptionSliderPercentage(int base, int min, int max, int step, OptionImpact impact, OptionFlag... optionFlags) {
super(base, min, max, step, impact, optionFlags);
}

@Override
public Control<Integer> getControl() {
return new SliderControl(this, min, max, step, NotFineControlValueFormatter.percentage());
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/jss/notfine/gui/NotFineGameOptionPages.java
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public static OptionPage atmosphere() {
.add(Settings.MODE_CLOUD_TRANSLUCENCY.option)
.add(Settings.MODE_STARS.option)
.add(Settings.TOTAL_STARS.option)
.add(Settings.FOG_NEAR.option)
.add(Settings.FOG_NEAR_DISTANCE.option)
.build());
return new OptionPage(I18n.format("options.button.sky"), ImmutableList.copyOf(groups));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ private boolean toggleWaterDetail(GameSettings settings) {
ordinal = 14
)
)
private void notFineGlFogF(int mode, float value) {
GL11.glFogf(mode, farPlaneDistance * (int)Settings.FOG_NEAR.option.getStore() * 0.01F - 1F);
private void notFine$nearFogDistance(int mode, float value) {
GL11.glFogf(mode, farPlaneDistance * (int)Settings.FOG_NEAR_DISTANCE.option.getStore() * 0.01F - 1F);
}

@Redirect(
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/assets/notfine/lang/en_US.lang
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ options.gui_background=Background
options.downfall_distance=Weather Effects
options.dynamic_fov=Dynamic FOV
options.dynamic_fov.tooltip=If enabled, the game's field of view will change based on the player's speed.
options.fog_near_distance=Near Fog Distance
options.mode_cloud_translucency=Cloud Translucency
options.mode_clouds=Clouds
options.mode_dropped_items=Dropped Items
Expand All @@ -40,4 +41,3 @@ options.title.sky=Atmosphere Settings
options.title.video=Video Settings
options.total_stars=Star Density
options.void_fog=Void Fog
options.fog_near=Near Fog Distance

0 comments on commit 369d636

Please sign in to comment.