Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow publishing with no version in config file #868

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 14, 2024

https://github.com/dsherret/jsr-publish-on-tag/actions/runs/12332179143/job/34419677355

$ deno publish --set-version 0.2.0
Download https://registry.npmjs.org/@types/node/-/node-18.16.19.tgz
Check file:///home/runner/work/jsr-publish-on-tag/jsr-publish-on-tag/src/main.ts
Checking for slow types in the public API...
Check file:///home/runner/work/jsr-publish-on-tag/jsr-publish-on-tag/src/main.ts
Publishing @david/[email protected] ...
error: Failed to publish @david/[email protected]
Caused by:
    Failed to publish @david/publish-on-tag at 0.2.0: invalid config file '/deno.json': missing field `version`
Error: Process completed with exit code 1.

Copy link
Member Author

@dsherret dsherret Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this code was broken up a bit so it was more easily testable. Something for another day.

@crowlKats
Copy link
Collaborator

can you update frontend/static/schema/config-file.v1.json?

@dsherret
Copy link
Member Author

Done.

@dsherret dsherret added this pull request to the merge queue Dec 14, 2024
Merged via the queue into main with commit 34603e9 Dec 14, 2024
6 checks passed
@dsherret dsherret deleted the fix_allow_publishing_no_version_config_file branch December 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants