Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent layout shift when hovering over doc header #867

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

aklinker1
Copy link
Contributor

@aklinker1 aklinker1 commented Dec 11, 2024

This closes #866, see issue for video of original issue. Resolves the shift caused by mismatch in the SVG and text heights.

Screen.Recording.2024-12-11.at.11.43.48.AM.mov

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@aklinker1 aklinker1 marked this pull request as ready for review December 11, 2024 20:24
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This annoyed me too.

@dsherret dsherret added this pull request to the merge queue Dec 14, 2024
Merged via the queue into jsr-io:main with commit f597b42 Dec 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout shift when hovering over header in docs
3 participants