Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render package search filters #804

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

crowlKats
Copy link
Collaborator

@crowlKats crowlKats commented Nov 1, 2024

Screenshot 2024-11-01 at 17 41 22

Also adds a link in the search result footer for filter syntax

Copy link
Contributor

@josh-collinsworth josh-collinsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing this doesn't seem to account for is longer text in a search box. This example might not be super likely, but with a larger font size/zoom and/or a small screen, this overflow can happen fairly easily:

CleanShot 2024-11-01 at 16 16 43@2x

When and if that does happen, the user's cursor isn't actually where the UI shows it being (because the input scrolls horizontally, but the visual does not), and it gets really weird. Can we find a way to account for this?

frontend/static/styles.css Outdated Show resolved Hide resolved
Copy link
Contributor

@josh-collinsworth josh-collinsworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some weird edge case behaviors here. Most notably, you can't scroll the input on Safari, and sometimes, when there's lots of text, the visible cursor gets slightly out of sync with the actual cursor position.

That said, I think these are edge-case-y enough to file them as bugs and run with this.

@crowlKats crowlKats added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 84b1e79 Nov 4, 2024
6 checks passed
@crowlKats crowlKats deleted the package-search-filter-render branch November 4, 2024 20:29
crowlKats added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants