-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render package search filters #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing this doesn't seem to account for is longer text in a search box. This example might not be super likely, but with a larger font size/zoom and/or a small screen, this overflow can happen fairly easily:
When and if that does happen, the user's cursor isn't actually where the UI shows it being (because the input scrolls horizontally, but the visual does not), and it gets really weird. Can we find a way to account for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some weird edge case behaviors here. Most notably, you can't scroll the input on Safari, and sometimes, when there's lots of text, the visible cursor gets slightly out of sync with the actual cursor position.
That said, I think these are edge-case-y enough to file them as bugs and run with this.
Also adds a link in the search result footer for filter syntax