Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change broken selection in enable_button_after parameter #3364

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Change broken selection in enable_button_after parameter #3364

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9230570
Change broken selection in enable_button_after parameter
levigoldberg Jul 29, 2024
cb0d13e
add changeset
jadeddelta Oct 30, 2024
fe53143
fix test cases
jadeddelta Nov 4, 2024
dd3caab
remove redundant clear of dom on test finish
jadeddelta Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-dogs-shave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@jspsych/plugin-html-button-response": patch
---

Change broken selection in enable_button_after parameter
4 changes: 2 additions & 2 deletions packages/plugin-html-button-response/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,12 @@ class HtmlButtonResponsePlugin implements JsPsychPlugin<Info> {

// disable all the buttons and set a timeout that enables them after a specified delay if timing is set
if (trial.enable_button_after > 0) {
var btns = document.querySelectorAll(".jspsych-html-button-response-button button");
var btns = document.querySelectorAll("#jspsych-html-button-response-btngroup button");
for (var i = 0; i < btns.length; i++) {
btns[i].setAttribute("disabled", "disabled");
}
this.jsPsych.pluginAPI.setTimeout(() => {
var btns = document.querySelectorAll(".jspsych-html-button-response-button button");
var btns = document.querySelectorAll("#jspsych-html-button-response-btngroup button");
for (var i = 0; i < btns.length; i++) {
btns[i].removeAttribute("disabled");
}
Expand Down
Loading