Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect path in dist gulp job (build:archive) #3293

Merged
merged 2 commits into from
May 15, 2024

Conversation

becky-gilbert
Copy link
Collaborator

This PR fixes a file path error in the createCoreDistArchive gulp task (build:archive), which has caused the dist archive to fail in the latest release.

I've tested this locally and can confirm that the dist build works and the survey.css file is included.

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: c04a3f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@jspsych/config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@becky-gilbert becky-gilbert self-assigned this May 15, 2024
@becky-gilbert becky-gilbert requested review from jodeleeuw and bjoluc May 15, 2024 17:27
Copy link
Member

@jodeleeuw jodeleeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I didn't catch this the first time 😶‍🌫️

@becky-gilbert
Copy link
Collaborator Author

sorry I didn't catch this the first time

Oh no, this was all on me 😬 Lessons learned!!

@becky-gilbert becky-gilbert merged commit 7bcd4e0 into main May 15, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 15, 2024
bjoluc pushed a commit that referenced this pull request Jun 7, 2024
* fix incorrect path in dist gulp job (build:archive)
* add changeset for config patch

(rebased-with-history from commit 7bcd4e0)
@bjoluc bjoluc deleted the fix-dist-job-error branch June 7, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants