Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS updates for v8 #3162

Merged
merged 8 commits into from
Jul 12, 2024
Merged

CSS updates for v8 #3162

merged 8 commits into from
Jul 12, 2024

Conversation

jodeleeuw
Copy link
Member

This currently fixes #2659.

Leaving it open in case we opt to make other CSS-related changes.

@jodeleeuw jodeleeuw added this to the 8.0 milestone Oct 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 1be7700

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
jspsych Major
@jspsych/plugin-canvas-button-response Patch
@jspsych/plugin-canvas-keyboard-response Patch
@jspsych/plugin-canvas-slider-response Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jodeleeuw jodeleeuw linked an issue Oct 24, 2023 that may be closed by this pull request
@bjoluc
Copy link
Member

bjoluc commented Nov 8, 2023

We should also address font loading (#2153 (comment)) to keep our CSS small. Sadly, that would require explicitly adding a font link tag to each and every experiment/example so people are aware of the google font loading and can remove/replace it if desired 😕

@jodeleeuw
Copy link
Member Author

This should now fix #1536 as well.

@jodeleeuw jodeleeuw merged commit 29e7451 into v8 Jul 12, 2024
4 checks passed
@jodeleeuw jodeleeuw deleted the v8-css-updates branch July 12, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants