-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use existing importmap for build by passing --map
flag
#2555
Conversation
--map
to be passed while using jspm build--map
flag
Looks good thanks. Any idea about the CI failure? Note that most CLI operations should automatically pick up the local |
Yes, the cli is picking the local build file by default. Needed only if we change the file name to something else than |
The CI failures are there for a while, should look into it. Something with assertions |
Fixed tests for one use-case. There is another use-case that is failing for Here is the error
The package |
Can we at least disable the test and post a new issue to reenable it? We can't land PRs if CI is failing... Otherwise looks good to land and thanks for clarifying |
Disabled |
Adds
--map
option forjspm build
command.While moving the
jspm-vscode
project to usejspm-cli
workflow. We will generate theimportmap.json
only once. And use it for re-runs or update it only when needed.So, when the extension is being built. We should use the existing map. Currently the
cli
throws an error because--map
is not allowed forbuild
command.Usage reference -> https://github.com/jspm/jspm-vscode/blob/refactor-build-workflow/chompfile.toml#L9
Eg