-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): Add build command by wrapping rollup #2544
Conversation
Made some resolution changes with the jspm build --build-config build-config.mjs downloads all the dependencies that are defined in the |
Crazy how this wraps the whole vite-plugin-jspm functionality 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, very exciting to see this one. Can you add some tests? Let me know if you need help getting them going.
Also documentation should be added in https://github.com/jspm/jspm-cli/tree/main/docs, which would then get added to the site. |
Thanks for the review @guybedford, good to see that the PR was in the right direction 😄. Will make the necessary changes, and see how we can integrate this with other commands. Like we have But if users are bundling the deps too. We don't need to add |
@guybedford made the final changes, and added the documentation for the same. Please check if need any changes/we can merge and release it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on the feedback here. I've left another couple of change requests. With those I think we could then approve and land and release. Ping me on discord if you want to discuss further at all.
Done with the directory changes 👍 |
c7a0e14
to
dcddeee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good down to the externals handling versus resolution errors.
Should i release |
Yes please! |
This PR aims to introduce the
build
command. Which will work in 2 modes. Basically the command wraps therollup
Node API with some defaults to run in simple mode. Where, we define some standard defaults and works with some projects out of the box.Then there is an another mode, where users can extend the behaviour with custom rollup setups. And the wrapper loads the config from the URL and starts the build.
is a simple rollup file. Which can have any defaults in it. Example
Which generates a output of
The
importmap.json
processing is not handled yet. But once done, it can bundlereact
fromjspm
CDN and include in the build.