Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using mikeal/request to gain proxy support #100

Merged
merged 4 commits into from
Aug 19, 2014

Conversation

tauren
Copy link

@tauren tauren commented Aug 19, 2014

Replaced https.get with request, added support for removing config settings, and passing proxy config through to endpoints.

Dependent upon the latest request package which includes automatic proxy support based on environment variables.

@guybedford
Copy link
Member

Awesome! This looks great. Is it not possible to convert the proxy config into environment config like we discussed, or is the no_proxy option still a blocker for this?

@tauren
Copy link
Author

tauren commented Aug 19, 2014

Note that this does NOT include the following:

  • jspm config proxy settings are not used and do not override environment proxy settings
  • no_proxy environment variables are ignored

guybedford added a commit that referenced this pull request Aug 19, 2014
Switch to using mikeal/request to gain proxy support
@guybedford guybedford merged commit 3c12876 into jspm:master Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants